----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52964/ -----------------------------------------------------------
(Updated Oct. 19, 2016, 5:52 p.m.) Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid Wagle. Changes ------- Missed one code block while rebasing. Unit tests passed again. Bugs: AMBARI-18619 https://issues.apache.org/jira/browse/AMBARI-18619 Repository: ambari Description ------- STR: * Deploy a 3-node cluster with Ambari 2.4 and HDP 2.5 with clients on every host. * Run multiple service checks in parallel, but notice that they typically run on the same 1 or 2 hosts. Currently, Ambari relies on getting the list of candidate hosts from the DB and excludes all hosts that are in maintenance mode. From that list, it picks the first host that is healthy (i.e., heartbeating). This means that the logic does not pick a random host. Instead, Ambari should always pick a random host and prefer to schedule on hosts that have 0 in-progress commands. Diffs (updated) ----- ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java a671f0c ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java 7418c1b ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java ef6d4c5 ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 17760c7 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 5556071 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java c06debb ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java d38108f ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProviderTest.java 2ccbcda ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java d96e7b5 Diff: https://reviews.apache.org/r/52964/diff/ Testing ------- mvn clean test Thanks, Alejandro Fernandez