> On Oct. 18, 2016, 9:15 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 2428 > > <https://reviews.apache.org/r/52839/diff/3/?file=1540784#file1540784line2428> > > > > nit: "Indicates the delay, in milliseconds, for the log4j monitor to > > check for changes" > > > > Something like that. We need to be very detailed so users/admins can > > understand exactly what a config knob is for.
implemented > On Oct. 18, 2016, 9:15 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > lines 963-964 > > <https://reviews.apache.org/r/52839/diff/3/?file=1540785#file1540785line963> > > > > These can be collapsed: > > LOG.error("Exception in setting log4j monitor delay of {} for {}", > > monitorDelay, log4jpath, e); implemented - Amarnath reddy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/#review153176 ----------------------------------------------------------- On Oct. 19, 2016, 10:51 p.m., Amarnath reddy pappu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52839/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2016, 10:51 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, > and Sid Wagle. > > > Bugs: AMBARI-18592 > https://issues.apache.org/jira/browse/AMBARI-18592 > > > Repository: ambari > > > Description > ------- > > Ability to enable the DEBUG logs in Ambari-server without server restart > > 1. PropertyConfigurator would check log4j.properties update every 5mins. if > there is any change in the file/timestamp it will reload the log4j > configurations. > 2. have defined to LOG4JMONITOR_DELAY for 5mins - 300000 milliseconds > 3. Have modified only for ambari-server > 4. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 378db18 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > c05840e > > Diff: https://reviews.apache.org/r/52839/diff/ > > > Testing > ------- > > 1. Change the log4j.properties from INFO to DEBUG > [Expected Result] server should start logging the DEBUG logs with in 5mins of > time. > [Resutl] PASS > > 2. Change the log4j.properties from DEBUG to INFO > [Expected Result] server should reduce the logging to INFO mode with in 5mins > of time. > [Resutl] PASS > > > Thanks, > > Amarnath reddy pappu > >
