> On Oct. 20, 2016, 9:11 p.m., Di Li wrote: > > contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_handler.js, > > line 1 > > <https://reviews.apache.org/r/53075/diff/1/?file=1542627#file1542627line1> > > > > Why a new file ? The changes are just the different way to referencing > > values in the dictionary, yes ?
I created a new file to rename it actionjob_hanlder to actionjob_handler. I had updated contrib/views/wfmanager/src/main/resources/ui/app/domain/node-handler.js where the file is being imported. > On Oct. 20, 2016, 9:11 p.m., Di Li wrote: > > contrib/views/wfmanager/src/main/resources/ui/app/domain/default-layout-manager.js, > > line 30 > > <https://reviews.apache.org/r/53075/diff/1/?file=1542629#file1542629line30> > > > > not really a functional issue though, more of a coding practice. Yes I agree, however JSHint flags it as an error because same variable is reused. > On Oct. 20, 2016, 9:11 p.m., Di Li wrote: > > contrib/views/wfmanager/src/main/resources/ui/app/routes/job.js, line 70 > > <https://reviews.apache.org/r/53075/diff/1/?file=1542640#file1542640line70> > > > > Should this one be checking for falsy instead of an exact null ? params would contain an array of search parameters which is set based on the last search. If no search was previously done, params would be null. > On Oct. 20, 2016, 9:11 p.m., Di Li wrote: > > contrib/views/wfmanager/src/main/resources/ui/app/services/property-extractor.js, > > line 30 > > <https://reviews.apache.org/r/53075/diff/1/?file=1542641#file1542641line30> > > > > Should this one be checking for falsy instead of an exact null ? same as previous comment. matches is a array. - Sangeeta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53075/#review153457 ----------------------------------------------------------- On Oct. 20, 2016, 8:41 p.m., Sangeeta Ravindran wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53075/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2016, 8:41 p.m.) > > > Review request for Ambari, Di Li and Yusaku Sako. > > > Bugs: AMBARI-18615 > https://issues.apache.org/jira/browse/AMBARI-18615 > > > Repository: ambari > > > Description > ------- > > When you compile the Workflow Manager view, you see 94 JSHint errors. > > Fix includes: > > 1) Adding a .jshintrc file for applying /*jshint esversion: 6 */ to the whole > project to address errors similar to 'import' is only available in ES6 (use > 'esversion: 6'). > 2) Adding semi-colons where they are missing. > 3) Using dot notation instead of array > > The patch also fixes the error due to incorrect version of > org.apache.ambari.contrib.views. > > The test failure for this patch is caused by an existing issue unrelated to > this patch. > > Failed to execute goal org.apache.maven.plugins:maven-war-plugin:2.4:war > (default-war) on project oozie-ui: The specified web.xml file > '/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/contrib/views/wfmanager/src/main/resources/ui/oozie-ambari-view/src/main/resources/WEB-INF/web.xml' > does not exist -> [Help 1] > > > Diffs > ----- > > contrib/views/wfmanager/.jshintrc PRE-CREATION > contrib/views/wfmanager/pom.xml 1e910e2 > contrib/views/wfmanager/src/main/resources/ui/README.md dcac346 > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > bd2944b > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-parameters.js > 1f75e64 > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-sla.js > dac325f > > contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_handler.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js > 33204ea > > contrib/views/wfmanager/src/main/resources/ui/app/domain/default-layout-manager.js > e208f83 > contrib/views/wfmanager/src/main/resources/ui/app/domain/layout-manager1.js > 0cd306a > contrib/views/wfmanager/src/main/resources/ui/app/domain/layout-manager2.js > d82b89e > contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js > 7cb82e1 > contrib/views/wfmanager/src/main/resources/ui/app/domain/node-handler.js > 49347d8 > contrib/views/wfmanager/src/main/resources/ui/app/domain/schema-versions.js > 9562ae8 > contrib/views/wfmanager/src/main/resources/ui/app/domain/sla-info.js > 76dffbd > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js > f29adb6 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js > 9fc791c > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js > 5908de5 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow_xml_mapper.js > d5dc4da > contrib/views/wfmanager/src/main/resources/ui/app/routes/job.js d849609 > > contrib/views/wfmanager/src/main/resources/ui/app/services/property-extractor.js > 17ff9aa > > Diff: https://reviews.apache.org/r/53075/diff/ > > > Testing > ------- > > Manual testing > > > File Attachments > ---------------- > > JSHint errors > > https://reviews.apache.org/media/uploaded/files/2016/10/20/c6a88e6d-d789-4f80-a7ca-9ec7b319331e__buildOutputJSHint_error.txt > > > Thanks, > > Sangeeta Ravindran > >
