> On Oct. 26, 2016, 4:38 p.m., Dmitro Lisnichenko wrote: > > ambari-agent/src/main/python/ambari_agent/HeartbeatHandlers.py, line 133 > > <https://reviews.apache.org/r/53194/diff/1/?file=1546322#file1546322line133> > > > > is it secure? Is any user able to interrupt process and execute > > arbitrary python code from console? > > Andrew Onischuk wrote: > This doesn't interrupt the process and not able to anyhow change it's > context. It's readonly view of it's state. > Also this is there for a long time, I have just moved it to other place.
I think the comment is incorrect there that's why it has confused you. I am gonna change the comment for that. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53194/#review153890 ----------------------------------------------------------- On Oct. 26, 2016, 4:25 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53194/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2016, 4:25 p.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-18704 > https://issues.apache.org/jira/browse/AMBARI-18704 > > > Repository: ambari > > > Description > ------- > > This is necessary to debug issues on agent level. Where logs doesn't give > enough insight. > > The commit will include: > > * possibility to debug second agent process without restarting agent > * show stack traces of where the process threads are without installing any > additional modules as a separate commit > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/HeartbeatHandlers.py 4a3d372 > ambari-agent/src/main/python/ambari_agent/RemoteDebugUtils.py f2a462b > ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 8959640 > > Diff: https://reviews.apache.org/r/53194/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >