> On Oct. 27, 2016, 6:49 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! > > Anita Jebaraj wrote: > Hi Dipayan, Can you please help in pushing the code. This is an isolated > change and hence wont impact the changes from Ambari-18691 > > DIPAYAN BHOWMICK wrote: > Done, have committed to trunk, branch-2.4 and branch-2.5.
Thank you - Anita ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53126/#review154063 ----------------------------------------------------------- On Oct. 27, 2016, 6:39 p.m., Anita Jebaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53126/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2016, 6:39 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, > Venkat Ranganathan, and Yusaku Sako. > > > Bugs: AMBARI-18665 > https://issues.apache.org/jira/browse/AMBARI-18665 > > > Repository: ambari > > > Description > ------- > > Workflow designer view doesn't execute on clicking the go to instance button > after creating the view. > Navigating to the Ambari dashboard and executing the view using the drop down > menu works and loads the workflow designer view > > > The issue is caused due to the space in the URI, it works in chrome and > firefox version 38.8, but does't work in the latest version of firefox > (49.0). The App.router.route handles it properly and so the menu redirect > works as expected, but the issue arises when the URI contains space in href. > > As per the standard practices, using spaces in URI is considered as unsafe, > hence the view name can be changed from Workflow Manager to WORKFLOW_MANAGER, > which will also be consistent with the other view names. > > > Diffs > ----- > > contrib/views/wfmanager/src/main/resources/view.xml ec3d5f5 > > Diff: https://reviews.apache.org/r/53126/diff/ > > > Testing > ------- > > Ran mvn test > > Performed manual testing. > > tested after applying the patch from jira AMBARI-18691, the issue still > exists and the patch is relevant. > > > Thanks, > > Anita Jebaraj > >
