----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53244/#review154081 -----------------------------------------------------------
Ship it! Ship It! - Alejandro Fernandez On Oct. 27, 2016, 11:35 p.m., Swapan Shridhar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53244/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2016, 11:35 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. > > > Bugs: AMBARI-18724 > https://issues.apache.org/jira/browse/AMBARI-18724 > > > Repository: ambari > > > Description > ------- > > **Issue** > 'hive.llap.zk.sm.connectionString' doesn't get updated when we upgrade from > HDP 2.4 -> 2.5, and continues to have default value 'localhost:2181'. > > > **Analysis:** > As there is no dependency defined for the configs to get updated, Stack > Advisor and/or UI will filter applying the sugested change by the Stack > Advisor code. Thats the reason even if SA code suggests the correct configs > value, its never applied. > > > **Fix** > Added a dependency of HSI config 'hive.llap.zk.sm.connectionString' on > 'enable_hive_interactive', so that 'hive.llap.zk.sm.connectionString' gets > updated. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml > 17f87ad > > Diff: https://reviews.apache.org/r/53244/diff/ > > > Testing > ------- > > Tested on an upgraded cluster. > It passes, and config value gets applied. > > > Thanks, > > Swapan Shridhar > >