> On Oct. 28, 2016, 4:04 a.m., Di Li wrote:
> > contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js,
> >  line 98
> > <https://reviews.apache.org/r/53103/diff/1/?file=1543254#file1543254line98>
> >
> >     Will "No messages present" be displayed in the log textarea ? can it be 
> > more of an error notification ?
> 
> Sangeeta Ravindran wrote:
>     Yes. But this will be displayed only when no messages are present in the 
> log. For e.g. when the job is in PREP state and hasn't run yet. Hence, it is 
> not always an error notification.

ok, thanks for the explanation.


- Di


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53103/#review154095
-----------------------------------------------------------


On Oct. 27, 2016, 9:56 p.m., Sangeeta Ravindran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53103/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2016, 9:56 p.m.)
> 
> 
> Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, 
> Venkat Ranganathan, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18600
>     https://issues.apache.org/jira/browse/AMBARI-18600
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In the workflow designer view instance, if there is no log available for the 
> workflow, then the spinner is seen giving the impression that logs are still 
> being retrieved. This happens for all the logs, viz. the job log, error log 
> and audit log.
> 
> A message sould be displayed when there are no messages in the log.
> 
> The test failure for this patch is caused by an existing issue unrelated to 
> this patch.
> 
> Failed to execute goal on project wfmanager: Could not resolve dependencies 
> for project org.apache.ambari.contrib.views:wfmanager:jar:0.1.0.0-SNAPSHOT: 
> Failure to find 
> org.apache.ambari.contrib.views:ambari-views-commons:jar:2.0.0.0-SNAPSHOT in 
> https://oss.sonatype.org/content/groups/staging was cached in the local 
> repository, resolution will not be reattempted until the update interval of 
> oss.sonatype.org has elapsed or updates are forced -> [Help 1]
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
> ce78e59 
> 
> Diff: https://reviews.apache.org/r/53103/diff/
> 
> 
> Testing
> -------
> 
> Manual tests.
> 
> 
> File Attachments
> ----------------
> 
> C:\Sangeeta\Work\BigData\Ambari\Jira Submissions\18600
>   
> https://reviews.apache.org/media/uploaded/files/2016/10/27/5b87e2e8-23e1-456c-ab5d-f157db437624__AMBARI-18600.patch
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Reply via email to