> On Nov. 1, 2016, 5:36 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py, > > line 234 > > <https://reviews.apache.org/r/53334/diff/1/?file=1550503#file1550503line234> > > > > Is this meant to account for a different Spark version in HDP stack? > > If so, we can use stack_features.json and the check_stack_feature > > function to make it more clear why this is the case.
yes, this is only for HDP 2.6 or later version. This is not feature, just a compablity break, so I think it is not necessary to put it in stack_features.json - Jeff ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53334/#review154422 ----------------------------------------------------------- On Nov. 1, 2016, 1:52 a.m., Jeff Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53334/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2016, 1:52 a.m.) > > > Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. > > > Bugs: AMBARI-18758 > https://issues.apache.org/jira/browse/AMBARI-18758 > > > Repository: ambari > > > Description > ------- > > 2 configuration key are changed. > > livy.server.kerberos.keytab --> livy.server.launch.kerberos.keytab > livy.server.kerberos.principal --> livy.server.launch.kerberos.principal > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py > 3a1c482 > > ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/kerberos.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/53334/diff/ > > > Testing > ------- > > I have verified it in HDP 2.6. But havn't done for the upgrade. > > @afernandez, do you know how to change the configuration key for upgrade ? I > didn't find samples in config-upgrade.xml > > > Thanks, > > Jeff Zhang > >
