> On Nov. 14, 2016, 6:42 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py, 
> > line 47
> > <https://reviews.apache.org/r/53705/diff/1/?file=1562721#file1562721line47>
> >
> >     We need to ensure this is deterministic. Please sort and then pick the 
> > element in index 0

Updated in latest patch


- Mugdha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53705/#review155827
-----------------------------------------------------------


On Nov. 15, 2016, 6:02 a.m., Mugdha Varadkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53705/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2016, 6:02 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> and Madhan Neethiraj.
> 
> 
> Bugs: AMBARI-18818
>     https://issues.apache.org/jira/browse/AMBARI-18818
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Following properties are need to be added in atlas under 
> application.properties from Ambari Configs to enable Knox SSO in Atlas
> atlas.sso.knox.enabled
> atlas.sso.knox.providerurl
> atlas.sso.knox.publicKey
> atlas.sso.knox.browser.useragent
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
>  95715b3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/application-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/atlas-log4j.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/metainfo.xml 
> 92db1f9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/themes/theme_version_2.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 49dd086 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> 8227d69 
> 
> Diff: https://reviews.apache.org/r/53705/diff/
> 
> 
> Testing
> -------
> 
> Tested Atlas installation with stack 2.6 on centos 6.
> 
> Test report for stack-advisor
> 
> Running tests for stack:2.6 service:common
> test_recommendAtlasConfigurations (test_stack_advisor.TestHDP26StackAdvisor) 
> ... ok
> test_recommendDruidConfigurations_WithDerby 
> (test_stack_advisor.TestHDP26StackAdvisor) ... ok
> test_recommendDruidConfigurations_WithPostgresql 
> (test_stack_advisor.TestHDP26StackAdvisor) ... ok
> test_recommendDruidConfigurations_heterogeneous_hosts 
> (test_stack_advisor.TestHDP26StackAdvisor) ... ok
> test_recommendDruidConfigurations_withMysql 
> (test_stack_advisor.TestHDP26StackAdvisor) ... ok
> 
> ----------------------------------------------------------------------
> Ran 5 tests in 2.550s
> 
> OK
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Reply via email to