----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53779/#review155914 -----------------------------------------------------------
ambari-server/src/main/resources/scripts/post-user-creation-hook.sh (line 54) <https://reviews.apache.org/r/53779/#comment226004> I think it would be better if Ambari passed in the search path to look for kinit rather than have the user set an environment variable. What if the user forgets to set it? - Robert Levas On Nov. 15, 2016, 6:33 a.m., Laszlo Puskas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53779/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2016, 6:33 a.m.) > > > Review request for Ambari, Robert Levas, Sandor Magyari, and Sebastian Toader. > > > Bugs: AMBARI-18894 > https://issues.apache.org/jira/browse/AMBARI-18894 > > > Repository: ambari > > > Description > ------- > > Kinit executable location may differ from the defaults in various deployments. > The post user creation hook takes the location from a system variable that > makes easy to customize the location. > (validation of the location availability of the executable is underway) > > > Diffs > ----- > > ambari-server/src/main/resources/scripts/post-user-creation-hook.sh 34169c1 > > Diff: https://reviews.apache.org/r/53779/diff/ > > > Testing > ------- > > Manually done on local env. > > > Thanks, > > Laszlo Puskas > >
