----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53780/#review156088 -----------------------------------------------------------
contrib/views/wfmanager/pom.xml (line 249) <https://reviews.apache.org/r/53780/#comment226223> MINOR: wfmanager/pom.xml has mixed tabs and spaces. Will be nice to keep it consistent. - Renjith Kamath On Nov. 15, 2016, 11:54 a.m., Nitiraj Rathore wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53780/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2016, 11:54 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Ashwin > Rajeev. > > > Bugs: AMBARI-18873 > https://issues.apache.org/jira/browse/AMBARI-18873 > > > Repository: ambari > > > Description > ------- > > Earlier : view jars were shipped with the ambari-server package. > Now : separate rpm and deb files can be created > (ambari-views-package_$VERSION.deb, ambari-views-package-$VERSION.x86_64.rpm) > which can be shipped and installed separately. > > each view (module) in contrib/views can copy its jar into the parent > (ambari-contrib-view project) target/views-jars folder and when mvn runs in > ambari-views-package, it creates an RPM and DEB file packaging all the jars. > > created RPM location : > $AMBARI/contrib/views/ambari-views-package/target/rpm/ambari-views-package/RPMS/x86_64/ambari-views-package-2.5.0.0-0.x86_64.rpm > create DEB location : > $AMBARI/contrib/views/ambari-views-package/target/ambari-views-package_2.5.0.0-0.deb > > The order of module ambari-views-package in pom.xml of ambari-contrib-views > should be last as it will create the package. > > command to create deb and rpm > $ cd $AMBARI/contrib/views > $ mvn clean package rpm:rpm jdeb:jdeb install > > > Diffs > ----- > > contrib/views/ambari-views-package/pom.xml PRE-CREATION > contrib/views/ambari-views-package/src/main/package/deb/control/control > PRE-CREATION > contrib/views/capacity-scheduler/pom.xml 7b7cdc9 > contrib/views/files/pom.xml 67beef9 > contrib/views/hawq/pom.xml 4fc543f > contrib/views/hive-next/pom.xml 46deaf3 > contrib/views/hive/pom.xml 2814049 > contrib/views/hueambarimigration/pom.xml 21837c3 > contrib/views/jobs/pom.xml 8460c5b > contrib/views/pig/pom.xml d2aada7 > contrib/views/pom.xml 94f8421 > contrib/views/slider/pom.xml 0ddcb84 > contrib/views/storm/pom.xml 38ec8ba > contrib/views/tez/pom.xml 26b0c49 > contrib/views/wfmanager/pom.xml e03e656 > contrib/views/zeppelin/pom.xml 52efdce > > Diff: https://reviews.apache.org/r/53780/diff/ > > > Testing > ------- > > manual testing of creation of > > > Thanks, > > Nitiraj Rathore > >
