> On Nov. 18, 2016, 4:56 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java, > > lines 912-913 > > <https://reviews.apache.org/r/53901/diff/1/?file=1567029#file1567029line912> > > > > Is this really a warning? It's not a problem if CUSTOMSERVICE says it > > wants to be after Kafka and Kafka isn't installed. > > > > Or is this a larger problem if "How does a service ensure it's always > > upgraded"? The service it chooses might not exist.
Thanks for the review! Basically I wanted to call out that if one of these CUSTOMSERVICE defines a generic upgrade pack, at least call out that there's a stack upgrade pack where it can't be applied. Existing logs don't make that very clear. Sometimes it's hard to weed out the real information among the ocean of INFOs. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53901/#review156342 ----------------------------------------------------------- On Nov. 18, 2016, 4:12 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53901/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2016, 4:12 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush > Luniya. > > > Bugs: AMBARI-18937 > https://issues.apache.org/jira/browse/AMBARI-18937 > > > Repository: ambari > > > Description > ------- > > Currently, a custom service can participate in RU/EU only if it adds an > Upgrade Pack for every target of a stack. If there is a case of the Upgrade > Pack ALWAYS being the same no matter the version, then only one file should > be sufficient. > > Also added that a group name must be unique in a XSD since the logic already > dictated that it must be true (and associated fixes). > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java > 37f4167 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java > edf5c89 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml > 95c5f06 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml > a01996a > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml > f0c6131 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml > f520faf > ambari-server/src/main/resources/upgrade-pack.xsd 2871f05 > > ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java > dde7ffa > > ambari-server/src/test/resources/stacks/HDP/2.2.0/services/GANGLIA/upgrades/HDP/rolling-upgrade.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/53901/diff/ > > > Testing > ------- > > Manual. Automated pending. > > > Thanks, > > Nate Cole > >
