----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53944/#review156488 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py (line 62) <https://reviews.apache.org/r/53944/#comment226667> if params.spark_version or params.spark2_version is None, then you cannot concatenate str and None objects. surround those variables with str(). ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py (line 44) <https://reviews.apache.org/r/53944/#comment226666> Use a "with" statement to close the file. Or explicitly close it in a finally block - Alejandro Fernandez On Nov. 21, 2016, 12:41 p.m., Renjith Kamath wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53944/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2016, 12:41 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav > Nagar, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-18946 > https://issues.apache.org/jira/browse/AMBARI-18946 > > > Repository: ambari > > > Description > ------- > > Initial support to Spark 1.x and 2.x config in Zeppelin > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 33a2a14 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py > 27ed150 > > Diff: https://reviews.apache.org/r/53944/diff/ > > > Testing > ------- > > manually tested on Centos > > > Thanks, > > Renjith Kamath > >
