> On Nov. 29, 2016, 4:29 p.m., Jonathan Hurley wrote: > > Ping. This looks like it was submitted. Can you close the review?
Done. Thanks for the reminder. - Sid ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53588/#review157270 ----------------------------------------------------------- On Nov. 16, 2016, 7:39 p.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53588/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2016, 7:39 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav > Papirkovskyy, and Sumit Mohanty. > > > Bugs: AMBARI-18827 > https://issues.apache.org/jira/browse/AMBARI-18827 > > > Repository: ambari > > > Description > ------- > > _Objectives_: > - Allow acceptors for agent and api connectors to be configurable > - The thread pool configuration did not take into account both 2-way and > 1-way connectors are configured for agent every time although only one is > used and not a mixed-mode. This causes insufficient threads in agent > threadpool for a high cpu core environment. > - Includes refactoring to remove code duplication. > > > Diffs > ----- > > ambari-server/docs/configuration/index.md 9d793ff > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 6a4eabf > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > ce3fe85 > > ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java > a1b5a6e > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > 844f022 > > Diff: https://reviews.apache.org/r/53588/diff/ > > > Testing > ------- > > Verified manually. > > 2-core VM ==> > Before patch: > [root@swagle-test-1 ~]# cat ~/jstack_before.out | grep > "ambari-agent.*Acceptor" | wc -l > 4 > [root@swagle-test-1 ~]# cat ~/jstack_before.out | grep > "ambari-agent.*Selector" | wc -l > 4 > [root@swagle-test-1 ambari-server]# cat ~/jstack_before.out | grep > "ambari-client.*Selector" | wc -l > 1 > [root@swagle-test-1 ambari-server]# cat ~/jstack_before.out | grep > "ambari-client.*Acceptor" | wc -l > 1 > > Default after patch: > [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep > "ambari-client.*Acceptor" | wc -l > 1 > [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep > "ambari-agent.*Acceptor" | wc -l > 1 > [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep > "ambari-client.*Selector" | wc -l > 1 > [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep > "ambari-agent.*Selector" | wc -l > 1 > > Setting configurations = 2: > [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep > "ambari-agent.*Selector" | wc -l > 2 > [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep > "ambari-client.*Selector" | wc -l > 2 > [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep > "ambari-agent.*Acceptor" | wc -l > 2 > [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep > "ambari-client.*Acceptor" | wc -l > 2 > > > File Attachments > ---------------- > > Enable both connectors > > https://reviews.apache.org/media/uploaded/files/2016/11/16/62b35d83-882e-4a64-8459-c1ad3849a88f__AMBARI-18827-1.patch > > > Thanks, > > Sid Wagle > >
