-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54189/
-----------------------------------------------------------
Review request for Ambari, Mugdha Varadkar, Sumit Mohanty, and Swapan Shridhar.
Bugs: AMBARI-19023
https://issues.apache.org/jira/browse/AMBARI-19023
Repository: ambari
Description
-------
Whenever adding an Atlas Server on a host, if the user executes the first
command as a "restart" (stop+start) instead of a "start" command, then the stop
command will fail because Ambari will not have generated any configs yet so
Atlas' atlas_stop.py will fail.
To fix it, during a stop command,
If the pid dir doesn't exist, this means either
1. The user just added Atlas service and issued a restart command (stop+start).
So stop should be a no-op since there's nothing to stop because the pid dir
does not exist.
OR
2. The user changed the value of the pid dir config and incorrectly issued a
restart command.
In which case the stop command cannot do anything since Ambari doesn't know
which process to kill.
The start command will spawn another instance.
The user should have issued a stop, changed the config, and then started it.
Diffs
-----
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
a469ebb
ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py
585dc94
Diff: https://reviews.apache.org/r/54189/diff/
Testing
-------
Verified on a life cluster.
Python unit tests passed.
----------------------------------------------------------------------
Total run:1166
Total errors:0
Total failures:0
OK
Thanks,
Alejandro Fernandez
