----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54377/#review158008 -----------------------------------------------------------
Ship it! Ship It! - Oliver Szabo On Dec. 5, 2016, 4:14 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54377/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2016, 4:14 p.m.) > > > Review request for Ambari, Vishal Ghugare, Robert Levas, and Sebastian Toader. > > > Bugs: AMBARI-19086 > https://issues.apache.org/jira/browse/AMBARI-19086 > > > Repository: ambari > > > Description > ------- > > Make sure GroupType is set to LDAP for users coming from LDAP. > > This is a quick fix. In the long run, the [ldap_group column will be > removed](https://issues.apache.org/jira/browse/AMBARI-18533) to reduce > duplication. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java > 58b2e5d > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java > 2f7bdd0 > > ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java > 1866b12 > > Diff: https://reviews.apache.org/r/54377/diff/ > > > Testing > ------- > > Manual test (install Ambari, replace ambari-server JAR, perform LDAP sync). > > Unit tests. > > > Thanks, > > Attila Doroszlai > >
