----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54536/#review158538 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java (line 135) <https://reviews.apache.org/r/54536/#comment229318> In both cases we create a connection, if it's https than it is also secured. I suggest to leave the declaration as it was, and then if https is the protocol invoke a secureConnection function. ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java (line 179) <https://reviews.apache.org/r/54536/#comment229314> The first 4 rows should be within the if statement too, they are only needed if sslSocketFactory is null, and thus it should be initiated. ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java (line 204) <https://reviews.apache.org/r/54536/#comment229315> Inadequate error message, just because the FileInputStream couldn't be closed the trust store was loaded. You may consider as well using try-with-resource, and then you don't need the finally part at all - Miklos Gergely On Dec. 8, 2016, 3:46 p.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54536/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2016, 3:46 p.m.) > > > Review request for Ambari, Miklos Gergely and Robert Nettleton. > > > Bugs: AMBARI-19104 > https://issues.apache.org/jira/browse/AMBARI-19104 > > > Repository: ambari > > > Description > ------- > > SSL support: use ambari server keystore for https connection in case if > logsearch is using ssl. > Most of the code is come from metrics code. (handling keystore part) > > (code not contains Keep-Alive header, that can minimizing the overhead of > establishing a secure connection) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImpl.java > b7e6365 > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java > 358c1b7 > > ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImplTest.java > 12b5b69 > > Diff: https://reviews.apache.org/r/54536/diff/ > > > Testing > ------- > > done. ft: manually craete credential and setup jks for logsearch > > > Thanks, > > Oliver Szabo > >
