> On Dec. 8, 2016, 3:08 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py, > > line 254 > > <https://reviews.apache.org/r/54527/diff/1/?file=1579794#file1579794line254> > > > > Should this provide the expanded value or just append > > {{heap_dump_opts}} so that if user changes heap dump path then it can take > > effect?
Done. - Swapan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54527/#review158526 ----------------------------------------------------------- On Dec. 8, 2016, 8:36 p.m., Swapan Shridhar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54527/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2016, 8:36 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. > > > Bugs: AMBARI-19138 > https://issues.apache.org/jira/browse/AMBARI-19138 > > > Repository: ambari > > > Description > ------- > > We need to add the heap dump option for: > > - All Hive services (Hive1/HiveServer2, Hive2/HiveServer2 and Metastore): > > -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=<'/tmp/' by default or > 'Configurable location provided'> > > option appended to "Advance hive-env" -> hive-env-template -> > HADOOP_CLIENT_OPTS environment variable > > - HSI YARN jobs: > > -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=<'/tmp/' by default or > 'Configurable location provided'> > > option added to "Advanced hive-interactive-env" -> Llap app java opts. Logs > will be generated at: /<'Configurable location > provided'>/java_<pid-of-llap-daemon>.hprof on the nodes that failed with OOM. > > - Tez: > > -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=<'/tmp/' by default or > 'Configurable location provided'> > > option added to tez.am.launch.cmd-opts for AM OOM and > tez.task.launch.cmd-opts for task OOM. > > > - 'Configurable location provided' should be one config where user can change > the location and consumable by all others. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 781cf5d > > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py > 6587151 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 775dbab > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml > 09e1741 > > ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-env.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-env.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.6/services/TEZ/configuration/tez-env.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.6/services/TEZ/configuration/tez-site.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py > bebeaf8 > > Diff: https://reviews.apache.org/r/54527/diff/ > > > Testing > ------- > > Manually on cluster. > Jenkins pending. > > > Thanks, > > Swapan Shridhar > >
