-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53727/#review158702
-----------------------------------------------------------


Fix it, then Ship it!




Fix it and ship it


ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/configuration/ranger-tagsync-site.xml
 (line 29)
<https://reviews.apache.org/r/53727/#comment229494>

    Set these to,
    <on-ambari-upgrade add="false"/>



ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml 
(line 28)
<https://reviews.apache.org/r/53727/#comment229495>

    Thanks for adding this section.



ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/configuration/ranger-ugsync-site.xml
 (line 23)
<https://reviews.apache.org/r/53727/#comment229493>

    Set all of these to, 
    <on-ambari-upgrade add="false"/>


- Alejandro Fernandez


On Dec. 8, 2016, 9:13 a.m., Vishal Suvagia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53727/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2016, 9:13 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Jayush Luniya, Mugdha Varadkar, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18874
>     https://issues.apache.org/jira/browse/AMBARI-18874
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Need to provide ssl related configurations for Ranger-Tagsync service.
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  46562e0 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  f2cc940 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py
>  9c6e142 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  8036f28 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/atlas-tagsync-ssl.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-tagsync-policymgr-ssl.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-tagsync-site.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER/0.7.0/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  27a755c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  66f872d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 1f7c1a8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/configuration/ranger-tagsync-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/configuration/ranger-ugsync-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml 
> a115134 
>   ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_tagsync.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-default.json 
> 1d5adff 
>   ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-secured.json 
> 030b717 
> 
> Diff: https://reviews.apache.org/r/53727/diff/
> 
> 
> Testing
> -------
> 
> Tested Ranger with Tagsync installation on CentOS 6.
> 
> Verified Unit-tests:
> 
> test_configure_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 
> 20:01:42,649 - Stack Feature Version Info: stack_version=2.6, 
> version=2.6.0.0-111, current_cluster_version=2.6.0.0-111 -> 2.6.0.0-111
> 2016-11-17 20:01:42,670 - Stack Feature Version Info: stack_version=2.6, 
> version=2.6.0.0-111, current_cluster_version=2.6.0.0-111 -> 2.6.0.0-111
> ok
> test_configure_secured (test_ranger_tagsync.TestRangerTagsync) ... ok
> test_start_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 
> 20:01:42,691 - Stack Feature Version Info: stack_version=2.6, 
> version=2.6.0.0-111, current_cluster_version=2.6.0.0-111 -> 2.6.0.0-111
> ok
> test_stop_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 
> 20:01:42,712 - Stack Feature Version Info: stack_version=2.6, 
> version=2.6.0.0-111, current_cluster_version=2.6.0.0-111 -> 2.6.0.0-111
> ok
> 
> 
> test_configure_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 
> 20:02:05,297 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> ok
> test_configure_secured (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 
> 20:02:05,318 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> ok
> test_start_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 
> 20:02:05,336 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> ok
> test_stop_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 
> 20:02:05,355 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> ok
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Reply via email to