----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54644/ -----------------------------------------------------------
Review request for Ambari, Oleg Nechiporenko, Xi Wang, and Yusaku Sako. Repository: ambari Description ------- Running "npm test" just hangs in Mac OS Sierra. Also while working on this ticket discovered that ambari-web unit tests as of now are getting short-circuit at https://github.com/apache/ambari/blob/branch-2.5/ambari-web/test/utils/configs/config_initializer_test.js#L954-L970 Thus no test of ambari-web after below file is getting executed as part of "mvn test" in ambari project. https://github.com/apache/ambari/blob/branch-2.5/ambari-web/app/assets/test/tests.js#L213 Diffs ----- ambari-web/app/assets/test/test.html d8ee080 ambari-web/package.json ad0bce4 ambari-web/test/controllers/main/admin/highAvailability/hawq/addStandby/step3_controller_test.js bd6a67a ambari-web/test/controllers/wizard/step9_test.js b0c4c20 ambari-web/test/utils/configs/config_initializer_test.js d348055 ambari-web/test/utils/date/date_test.js 3d61c90 ambari-web/test/utils/date/timezone_test.js da89586 ambari-web/test/views/common/configs/widgets/slider_config_widget_view_test.js a6b25ce Diff: https://reviews.apache.org/r/54644/diff/ Testing ------- Verified that all ambari-web unit tests run: Verified that ambari-web unit test runs on Mac OS X El Capitan, Mac OS Sierra and Ubuntu. npm test: 29760 passing (20s) 154 pending Thanks, Jaimin Jetly
