----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54778/#review159284 -----------------------------------------------------------
Ship it! Ship It! Do not forget to copy every property value (also which was renamed etc.) from logserch-env to logsearch-portal-env during upgrade - Oliver Szabo On Dec. 15, 2016, 12:23 p.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54778/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2016, 12:23 p.m.) > > > Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-19209 > https://issues.apache.org/jira/browse/AMBARI-19209 > > > Repository: ambari > > > Description > ------- > > Some properties in logsearch-env are affecting both the portal and the > feeders, while others affect only the portal. The latter should be separated > into a logsearch-portal-env, so logfeeders will be restarted only if those > properties are changed which affect the whole service. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImpl.java > 0fc5cd9 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json > 537d7fa > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml > aba638a > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml > 8691d35 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-portal-env.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json > 49d1b10 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml > 6921a8e > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > 4d751ba > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/status_params.py > 3046452 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json > b6f6a09 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json > 2858825 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > fa61944 > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > 3789a16 > > ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImplTest.java > 3ca978c > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 6317376 > ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py > c3e8930 > ambari-server/src/test/python/stacks/2.4/configs/default.json 7591adb > ambari-web/app/data/HDP2/site_properties.js e2a4d4e > ambari-web/app/models/quick_links.js 00dfd1c > ambari-web/app/views/common/modal_popups/log_tail_popup.js 4dae7a4 > > Diff: https://reviews.apache.org/r/54778/diff/ > > > Testing > ------- > > Tested on local cluster > > > Thanks, > > Miklos Gergely > >