----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54864/#review159621 -----------------------------------------------------------
Ship it! Ship It! - Tim Thorpe On Dec. 19, 2016, 4:58 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54864/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2016, 4:58 p.m.) > > > Review request for Ambari and Tim Thorpe. > > > Bugs: AMBARI-19225 > https://issues.apache.org/jira/browse/AMBARI-19225 > > > Repository: ambari > > > Description > ------- > > Ambari server should prints error messages to its log if it can't find > property for given property attribute type, such as NOT_MANAGED_HDFS_PATH > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 3fb036d > > Diff: https://reviews.apache.org/r/54864/diff/ > > > Testing > ------- > > 1. existing unit tests > 2. patch a trunk cluster with the code change, modify HDFS configuration > hadoop-env in the ambari db to remove hdfs_tmp_dir. Verify hdfs restart > finishes successfully without errotd. ambari-server.log has error messages > about unable to find the property within the given config type for the > particular configuration version tag. > > > Thanks, > > Di Li > >
