----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54944/#review159888 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java (line 67) <https://reviews.apache.org/r/54944/#comment230940> Why is this hardcoded ? - Sid Wagle On Dec. 21, 2016, 9:23 p.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54944/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2016, 9:23 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-19273 > https://issues.apache.org/jira/browse/AMBARI-19273 > > > Repository: ambari > > > Description > ------- > > Enable AmbariServer metrics by default. Currently, the metrics.properties > file is not part of the rpm and hence the Metrics system does not do start up. > > Also, have a global flag in ambari.properties for disabling AmbariServer > metrics altogether. > > > Diffs > ----- > > ambari-server/conf/unix/metrics.properties 5f01e39 > ambari-server/conf/windows/metrics.properties PRE-CREATION > ambari-server/src/main/assemblies/server-windows.xml 191fcfb > ambari-server/src/main/assemblies/server.xml 9a193a9 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 43fff0b > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > dcc56c9 > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java > 809176be > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java > 23845c9 > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSink.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java > cf10408 > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/SingleMetric.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java > 58e2045 > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java > d42dbdf > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java > 705971f > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java > a04ca43 > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsConfiguration.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java > 1645ebf > > ambari-server/src/test/java/org/apache/ambari/server/metric/system/impl/JvmMetricsSourceTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/metric/system/impl/MetricsServiceTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/metric/system/impl/TestAmbariMetricsSinkImpl.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/metric/system/impl/TestMetricsSource.java > PRE-CREATION > ambari-server/src/test/resources/metrics.properties PRE-CREATION > > Diff: https://reviews.apache.org/r/54944/diff/ > > > Testing > ------- > > mvn clean package > Manually tested. > ambari-server unit test pending. > > > File Attachments > ---------------- > > Grafana dashboard (with minor tweaks) > > https://reviews.apache.org/media/uploaded/files/2016/12/21/99b92a12-9104-46db-b001-fdaaa678ff82__Screen_Shot_2016-12-21_at_11.03.57_AM.png > > > Thanks, > > Aravindan Vijayan > >
