> On Dec. 22, 2016, 12:12 a.m., Sid Wagle wrote: > > ambari-metrics/ambari-metrics-timelineservice/conf/windows/metrics_whitelist, > > line 1 > > <https://reviews.apache.org/r/54609/diff/3/?file=1586582#file1586582line1> > > > > No hive metrics?
They are present in the whitelist. Examples are that starting with "default.General." & "executors." - Aravindan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54609/#review159887 ----------------------------------------------------------- On Dec. 15, 2016, 8:03 p.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54609/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2016, 8:03 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-19141 > https://issues.apache.org/jira/browse/AMBARI-19141 > > > Repository: ambari > > > Description > ------- > > Ability to specify metric expressions for whitelisting. > Metric expressions need to be specified with a prefix (._p_). > > Ability to blacklist metrics from entire sources (APP_IDs) > For example, config can look like ams-site : > timeline.metrics.apps.blacklist=hbase,namenode,datanode > > > Metadata changes > Non whitelisted metrics will also be tracked through the metadata. > http:<AMS_HOST>:6188/ws/v1/timeline/metrics/metadata will return only > whitelisted metrics (if whitelisting is enabled). > http:<AMS_HOST>:6188/ws/v1/timeline/metrics/metadata?query=all will return > all metrics. > > > Diffs > ----- > > ambari-metrics/ambari-metrics-assembly/pom.xml a55ae57 > > ambari-metrics/ambari-metrics-assembly/src/main/assembly/collector-windows.xml > 4f1ad47 > ambari-metrics/ambari-metrics-assembly/src/main/assembly/collector.xml > 609ddb3 > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetricMetadata.java > 1f413a0 > ambari-metrics/ambari-metrics-timelineservice/conf/unix/metrics_whitelist > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/conf/windows/metrics_whitelist > PRE-CREATION > ambari-metrics/ambari-metrics-timelineservice/pom.xml a32ba00 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java > 844ee41 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java > f40dd6c > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java > 27caf88 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java > 57186f5 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilter.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/AggregatorUtils.java > 55b1c1b > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricAppAggregator.java > 0d6a09e > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TimelineMetricMetadataManager.java > 3e4fc5f > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java > bc218f2 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java > 6b15e29 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java > 2e2d3a8 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilterTest.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TestMetadataManager.java > 2809640 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TestMetadataSync.java > 78f2bfe > > ambari-metrics/ambari-metrics-timelineservice/src/test/resources/test_data/metric_whitelist.dat > PRE-CREATION > > Diff: https://reviews.apache.org/r/54609/diff/ > > > Testing > ------- > > Manually tested. > mvn clean test on ambari-metrics passed. > > > Thanks, > > Aravindan Vijayan > >
