----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54981/#review159965 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On Dec. 22, 2016, 5:09 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54981/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2016, 5:09 p.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-19282 > https://issues.apache.org/jira/browse/AMBARI-19282 > > > Repository: ambari > > > Description > ------- > > In the command json file the hostname is in lower case, while in HA mode the > hdfs-site property dfs.namenode.rpc-address.{dfs_ha_nameservices}.{nn_id} may > have upper case parts, which prevents the /common- > services/HDFS/<version>/package/scripts/params_linux.py file at line 300 from > identifying the namenode_id, as it tries to find the hostname in the proprety, > and their case doesn't match. > > Either it should be fixed that the dfs.namenode.rpc- > address.{dfs_ha_nameservices}.{nn_id} should be always in lower case too or > the params_linux.py should identify the namenode_id by trying to find the > hostname in the property ignoring case. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > 0aac45e > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_windows.py > da00985 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 72e5196 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py > daba3d3 > > Diff: https://reviews.apache.org/r/54981/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
