----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55371/#review161051 -----------------------------------------------------------
contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/components/directory-viewer.js (line 120) <https://reviews.apache.org/r/55371/#comment232313> length is calculated multiple times. It can be done in a variable and then make use of that variable. - Pallav Kulshreshtha On Jan. 10, 2017, 7:18 a.m., Padma Priya N wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55371/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2017, 7:18 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Pallav Kulshreshtha. > > > Bugs: AMBARI-19436 > https://issues.apache.org/jira/browse/AMBARI-19436 > > > Repository: ambari > > > Description > ------- > > Need ability to upload a file in HDFS browser. > > > Diffs > ----- > > contrib/views/wfmanager/src/main/resources/ui/app/components/file-upload.js > 5ea37b5 > > contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js > 47e7983 > > contrib/views/wfmanager/src/main/resources/ui/app/services/hdfs-file-uploader.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs > 4f9b4ce > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/components/directory-viewer.js > 991d122 > > contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/hdfs-file-uploader-test.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/55371/diff/ > > > Testing > ------- > > Manual > > > Thanks, > > Padma Priya N > >
