> On Jan. 9, 2017, 7:24 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, > > line 704 > > <https://reviews.apache.org/r/46268/diff/1/?file=1599942#file1599942line704> > > > > Please add some javadoc.
Updated in latest patch > On Jan. 9, 2017, 7:24 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/ranger-storm-plugin-properties.xml, > > line 31 > > <https://reviews.apache.org/r/46268/diff/1/?file=1599966#file1599966line31> > > > > Set <on-ambari-upgrade add="false"/> for all props since EU/RU will add > > them. Need this property from stack 2.5 onwards. Added those peoperties as true since stack 2.5 is released and user doing ambari-upgrade with stack 2.5 will get the property. - Mugdha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46268/#review160934 ----------------------------------------------------------- On Jan. 10, 2017, 1:31 p.m., Mugdha Varadkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46268/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2017, 1:31 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, > Jayush Luniya, Sumit Mohanty, and Velmurugan Periasamy. > > > Bugs: AMBARI-19044 > https://issues.apache.org/jira/browse/AMBARI-19044 > > > Repository: ambari > > > Description > ------- > > Currently, Ambari provides a single toggle button to enable Ranger plugins > for a component. Plugin enabled results in a bunch of configuration which are > created on backend which are tighly coupled with Ranger admin installed on > the same cluster. > > Need to make sure plugins communicate to Ranger admin which is installed on > separate cluster. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > a352f71 > > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py > 537aaa0 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > 172cbd4 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > 8704d3e > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/setup_ranger_atlas.py > f5d7f38 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 8eed2d5 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py > 0d73e39 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > f804851 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py > e3aff9d > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 61034cf > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py > 81a4e3e > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 41970f8 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py > 3a9f51e > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-audit.xml > b4c0790 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-plugin-properties.xml > 3949402 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-policymgr-ssl.xml > cf4a82e > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-security.xml > 91061d1 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml > ae9314b > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 4a23bca > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py > d4eb6b9 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml > 95e653c > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-audit.xml > 4dc51eb > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-policymgr-ssl.xml > b1f6e1e > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-security.xml > 983702f > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py > 67d5769 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py > caafd55 > > ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/ranger-storm-plugin-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 017df91 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py > 3117139 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/setup_ranger_yarn.py > 6ea7f82 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > b94d376 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml > 960c751 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml > c57c5f0 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/ranger-hive-plugin-properties.xml > 830c539 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/ranger-knox-plugin-properties.xml > d5880dd > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > cf7134e > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-audit.xml > 85c16c8 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-policymgr-ssl.xml > c761b26 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-security.xml > 1deb9e5 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-policymgr-ssl.xml > 71ba3a6 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-security.xml > cfd8a4f > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-audit.xml > b210fca > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-policymgr-ssl.xml > a538843 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-security.xml > ce4074a > > ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-policymgr-ssl.xml > 24fd407 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-audit.xml > 1f3c1d1 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-policymgr-ssl.xml > bb0878f > > ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-security.xml > 9bd1079 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-policymgr-ssl.xml > 5672f04 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-security.xml > f3d7530 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-audit.xml > a6b1baa > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-plugin-properties.xml > 97867cc > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-policymgr-ssl.xml > 5410104 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-security.xml > 5f69962 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > e09ffde > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-audit.xml > 36677a1 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-plugin-properties.xml > fd623cb > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-policymgr-ssl.xml > dcffb63 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-security.xml > ea0a026 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/configuration/ranger-hbase-plugin-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml > 77f7be2 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/ranger-hive-plugin-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/ranger-hive-security.xml > 1d1b0c2 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/configuration/ranger-kafka-plugin-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.5/services/KNOX/configuration/ranger-knox-plugin-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/ranger-storm-policymgr-ssl.xml > 5672f04 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/ranger-storm-security.xml > f3d7530 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/configuration/ranger-yarn-plugin-properties.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > ddf407e > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > 98aaa0f > ambari-server/src/test/python/stacks/2.0.6/configs/default.json f54b645 > ambari-server/src/test/python/stacks/2.0.6/configs/default_client.json > 5659ba6 > ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json > be8866d > > ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json > ede360b > > ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json > d49868f > ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json > 5b8a0af > ambari-server/src/test/python/stacks/2.0.6/configs/default_with_bucket.json > a0e7e9d > ambari-server/src/test/python/stacks/2.0.6/configs/hbase-2.2.json e6a8676 > > ambari-server/src/test/python/stacks/2.0.6/configs/hbase-rs-2.2-phoenix.json > b1d603b > ambari-server/src/test/python/stacks/2.0.6/configs/hbase-rs-2.2.json > 435291a > ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 890b9f1 > ambari-server/src/test/python/stacks/2.0.6/configs/secured_client.json > 699c1f5 > ambari-server/src/test/python/stacks/2.1/configs/default-storm-start.json > 92a7516 > ambari-server/src/test/python/stacks/2.1/configs/default.json 6ee7612 > ambari-server/src/test/python/stacks/2.1/configs/secured-storm-start.json > 9bd239c > ambari-server/src/test/python/stacks/2.1/configs/secured.json 0e4bfc3 > ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py > 02be812 > ambari-server/src/test/python/stacks/2.2/configs/default.json 7583e27 > ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json cb476d3 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 378522e > ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json ffdd5e9 > ambari-server/src/test/python/stacks/2.5/configs/hsi_ha.json def0e54 > ambari-web/app/controllers/main/service/info/configs.js e718835 > ambari-web/app/controllers/wizard/step7_controller.js 3d22fe9 > > Diff: https://reviews.apache.org/r/46268/diff/ > > > Testing > ------- > > mvn -DskipPythonTests -Dtest=UpgradeCatalog250Test test > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m > -Djava.awt.headless=true > Running org.apache.ambari.server.upgrade.UpgradeCatalog250Test > Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.993 sec - > in org.apache.ambari.server.upgrade.UpgradeCatalog250Test > > Results : > > Tests run: 9, Failures: 0, Errors: 0, Skipped: 0 > > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 54.262s > [INFO] Finished at: Mon Jan 09 13:59:40 UTC 2017 > [INFO] Final Memory: 58M/766M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Mugdha Varadkar > >
