> On Jan. 9, 2017, 7:26 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml,
> > line 22
> > <https://reviews.apache.org/r/54970/diff/3/?file=1591716#file1591716line22>
> >
> > If the user edited the config in HDP 2.3 or 2.4 from the original value
> > of "*=spark-conf", should an upgrade to HDP 2.5 keep their edited value of
> > forcibly change it to "*={{spark_conf_dir}}"?
> >
> > If the answer is keep their current value, then no change needed.
> > If it must force it to "*={{spark_conf_dir}}", then this will also
> > require a change in the EU/RU upgrade packs to set the config value.
>
> ping wang wrote:
> Hi Alejandro,
> Thanks for comment.
> I think the upgrade will keep the user edited value. If so "no change
> needed", does this mean for any existing property the default value defined
> in common-service can not be changed anymore?
> @dili, what's your view about this?
>
> Thanks a lot!
Basically, if the user edited the value, does EU/RU need to forcibly change it
to "*={{spark_conf_dir}}"? Today, the default behavior is to persist the user's
modified value. If you want to forcibly change it to "*={{spark_conf_dir}}",
then it will need to modify the EU/RU upgrade packs and config packs.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review160940
-----------------------------------------------------------
On Dec. 24, 2016, 7:12 a.m., ping wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2016, 7:12 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Di Li.
>
>
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Change default Spark configuration property in Oozie configuration settings
> to valid value
>
>
> Diffs
> -----
>
>
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
> a2d725c
>
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
> cdb6972
>
> Diff: https://reviews.apache.org/r/54970/diff/
>
>
> Testing
> -------
>
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory
> correctly
>
>
> Thanks,
>
> ping wang
>
>
