> On Jan. 13, 2017, 10:06 p.m., Siddharth Seth wrote: > > Looked at the changes in stack-advisor. Mostly look good to me. > > Was a little confused by the change to minContainerSize based on whether > > the used change the yarn min-allocation-mb property.
So the scenarios that I am trying to capture are: * Initial cluster creation - SA will ignore what value it gets in yarn-site and use the computation strategy it has * Validation call, call when user lands on an UI page, call when any other config changes - SA will use whatever value that comes through "yarn-site" (this is by definition considered an user provided value) * If user change the min container size then it will be indicated in the changed_configuration[] section and then the user supplied new value is used. - Sumit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55482/#review161592 ----------------------------------------------------------- On Jan. 13, 2017, 1:41 a.m., Sumit Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55482/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2017, 1:41 a.m.) > > > Review request for Ambari, Siddharth Seth, Swapan Shridhar, and Sid Wagle. > > > Repository: ambari > > > Description > ------- > > A large value for YARN min container size reduces the number of AMs that can > be created for llap. > > > Diffs > ----- > > ambari-server/src/main/resources/scripts/stack_advisor.py abfab87 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 480e73d > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > cf7134e > ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py > d781147 > ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py > 02be812 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 378522e > ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py > a7ccdfe > > Diff: https://reviews.apache.org/r/55482/diff/ > > > Testing > ------- > > Ran all stack advisor tests manually. > > ---------------------------------------------------------------------- > Ran 270 tests in 6.771s > > OK > ---------------------------------------------------------------------- > Total run:1151 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Sumit Mohanty > >
