> On Jan. 16, 2017, 1:40 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/PERF/install_packages.py, line 41 > > <https://reviews.apache.org/r/55515/diff/1/?file=1605019#file1605019line41> > > > > How much of this was copied from the one in HDP? > > Can we derive both from a base class?
As the PERF stack is a fake stack used for specific tests, I don't think any production code should be derived from it. It's fine if PERF extends/overrides real stack code and alters behavior, but we should not have both test and production code trying to have shared logic. a - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55515/#review161768 ----------------------------------------------------------- On Jan. 13, 2017, 2:03 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55515/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2017, 2:03 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, > and Vitalyi Brodetskyi. > > > Bugs: AMBARI-18739 > https://issues.apache.org/jira/browse/AMBARI-18739 > > > Repository: ambari > > > Description > ------- > > Also includes code for AMBARI-18738. Perf: Allow components to report their > version using distro-select and change configs using conf-select > > In order to run Rolling/Express Upgrade, will need to create the > Rolling/NonRolling Upgrade Packs and potentially config packs if we decide to > do it across major versions. > > This means each service will need to support start commands with the > upgrade_type option, have symlinks already in distro-select, etc. > > At first, this can be a handful of services. > The goal is to simulate Rolling/Express Upgrade on the PERF stack. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/PythonExecutor.py d75fc0cef2 > > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py > 513ceac8dd > > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py > 615a0cdcbc > ambari-common/src/main/python/resource_management/libraries/script/dummy.py > 3dcece501d > ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py > 4dec16f372 > ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py > d70e87fb1e > > ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/distro-select.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py > 9eca9ec724 > > ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py > 9eca9ec724 > > ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py > 9eca9ec724 > > ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py > 9eca9ec724 > ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 > ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 > ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 > ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml > c5137fb133 > ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml > c5137fb133 > > ambari-server/src/main/resources/stacks/PERF/1.0/services/GRUMPY/metainfo.xml > 15c5cfddd2 > > ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/metainfo.xml > 53cc11b7eb > > ambari-server/src/main/resources/stacks/PERF/1.0/services/HBASE/metainfo.xml > f1f4b7d1ac > ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/metainfo.xml > 42edc8d493 > > ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/datanode.py > 6fc338b1da > > ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/journalnode.py > 96be63060a > > ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/namenode.py > c3488e8bcc > > ambari-server/src/main/resources/stacks/PERF/1.0/services/SLEEPY/metainfo.xml > 5b4dbd4a2d > ambari-server/src/main/resources/stacks/PERF/1.0/services/SNOW/metainfo.xml > 21e685ad80 > ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/metainfo.xml > bb2191b267 > > ambari-server/src/main/resources/stacks/PERF/1.0/services/ZOOKEEPER/metainfo.xml > 57667bb888 > > ambari-server/src/main/resources/stacks/PERF/1.0/upgrades/nonrolling-upgrade-2.0.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/PERF/1.0/upgrades/upgrade-2.0.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/PERF/install_packages.py > PRE-CREATION > contrib/utils/perf/deploy-gce-perf-cluster.py 8ba7e42e0b > > Diff: https://reviews.apache.org/r/55515/diff/ > > > Testing > ------- > > Tested on my local 3-node cluster (both upgrade and downgrade). > Script for creating Perf cluster downloads Ambari code from Apache git, so > did not manage to test on gce, but script should work too (added required > code). > > What works: > - deploy of Perf 1.0 cluster > - RU to 2.0 (upgrade and downgrade) > - EU to 2.0 (upgrade and downgrade) > > Issues: > - Clean deploy of perf 2.0 stack (dummy component install scripts are > hardcoded with 1.1.1.1 version) > > > Thanks, > > Dmitro Lisnichenko > >
