> On Feb. 27, 2017, 2:39 p.m., Balázs Bence Sári wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java, > > line 232 > > <https://reviews.apache.org/r/56980/diff/2/?file=1650134#file1650134line232> > > > > What does the comment mean? > > Attila Magyar wrote: > We don't cache keytab files that belong to servie principals. The error > should be added only if the principal is a non service principal (cache > should have been existed) but there is no cached keytab file
Now that the condition has been inverted it is in line with the comment. - Balázs Bence ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56980/#review166868 ----------------------------------------------------------- On Feb. 27, 2017, 2:58 p.m., Attila Magyar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56980/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2017, 2:58 p.m.) > > > Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, > and Sebastian Toader. > > > Bugs: AMBARI-20140 > https://issues.apache.org/jira/browse/AMBARI-20140 > > > Repository: ambari > > > Description > ------- > > Spark2 and Spark1 shares the same principal name. This casuses a problem when > adding Spark2 to a kerberized cluster with Spark1. Ambari doesn't publish the > keytab to Spark2 because it thinks it already exists. > > I extended the existing conditional to take the existence of the destination > keytab file into consideration. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java > b968383 > > Diff: https://reviews.apache.org/r/56980/diff/ > > > Testing > ------- > > - Created a cluster with Spark > - Enabled Kerberos > - Added Spark2 > - Checked if Spark2 started successfully and the exitence of > /etc/security/keytabs/spark2.headless.keytab > > > Existing tests ran without failure. > > > Thanks, > > Attila Magyar > >
