> On Feb. 27, 2017, 6:41 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json, > > line 25 > > <https://reviews.apache.org/r/57096/diff/1/?file=1650510#file1650510line25> > > > > This is also needed in HDP 3.0 > > Madhuvanthi Radhakrishnan wrote: > I have added this change in > ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.json > and attached a trunk patch to the apache jira.
@Alejandro, For HDP-3.0 what is going to be the min HDP version from which we will be upgrading? We should look at all the places where we have stack-version specific logic and do a code cleanup to remove these if-else blocks. - Jayush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57096/#review166905 ----------------------------------------------------------- On Feb. 27, 2017, 7:10 p.m., Madhuvanthi Radhakrishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57096/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2017, 7:10 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jayush Luniya. > > > Bugs: AMBARI-20212 > https://issues.apache.org/jira/browse/AMBARI-20212 > > > Repository: ambari > > > Description > ------- > > Remove HDP version check in KAFKA service > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py > 015e150 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > bc2e7a7 > > Diff: https://reviews.apache.org/r/57096/diff/ > > > Testing > ------- > > > Thanks, > > Madhuvanthi Radhakrishnan > >
