----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57198/#review167259 -----------------------------------------------------------
Ship it! Ship It! - Gaurav Nagar On March 1, 2017, 10:23 a.m., Nitiraj Rathore wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57198/ > ----------------------------------------------------------- > > (Updated March 1, 2017, 10:23 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20181 > https://issues.apache.org/jira/browse/AMBARI-20181 > > > Repository: ambari > > > Description > ------- > > added back ticks in the query > > > Diffs > ----- > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnInfo.java > 9f179d1 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/CreateTableQueryGenerator.java > eab3a4b > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java > 42cec0a > > contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/CreateTableQueryGeneratorTest.java > f5a9778 > > contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGeneratorSpecTest.groovy > PRE-CREATION > > > Diff: https://reviews.apache.org/r/57198/diff/1/ > > > Testing > ------- > > added InsertFromQueryGeneratorSpecTest.groovy test class > > > Thanks, > > Nitiraj Rathore > >