----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57202/#review167285 -----------------------------------------------------------
Ship it! Ship It! - Aleksandr Kovalenko On Март 1, 2017, 3:05 п.п., Andrii Tkach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57202/ > ----------------------------------------------------------- > > (Updated Март 1, 2017, 3:05 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-20255 > https://issues.apache.org/jira/browse/AMBARI-20255 > > > Repository: ambari > > > Description > ------- > > I've seen cases where you go back to the Hosts page and the paging filter on > the bottom is showing page 1, but page 2 results are shown. > Repro scenario: > Go to Hosts page > Apply a valid filter (Host Status: Slave Down) > Go to page 2 > Click on "Services" from the top nav > Go back to Hosts page. Initially, the hosts from the original filter are > shown (but the filter is cleared). Then the hosts with no filters show up, > but the page is still showing 2 > > > Diffs > ----- > > ambari-web/app/controllers/global/update_controller.js 75b4a00 > ambari-web/app/controllers/main/host.js 336bd25 > ambari-web/app/mixins/common/table_server_view_mixin.js 4e982d7 > ambari-web/app/views/common/table_view.js 9fcefc7 > ambari-web/app/views/main/host.js 8959dde > ambari-web/test/mixins/common/table_server_view_mixin_test.js 2a9c409 > ambari-web/test/views/common/table_view_test.js 37dd911 > ambari-web/test/views/main/host_test.js a5fce45 > > > Diff: https://reviews.apache.org/r/57202/diff/1/ > > > Testing > ------- > > 20574 passing (34s) > 153 pending > > > Thanks, > > Andrii Tkach > >