----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57139/ -----------------------------------------------------------
(Updated March 2, 2017, 10:52 a.m.) Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, Mugdha Varadkar, Sumit Mohanty, and Sriharsha Chintalapani. Changes ------- Updating code to remove leading and trailing whitespaces, adding testcases to cover sasl scenario. Bugs: AMBARI-20208 https://issues.apache.org/jira/browse/AMBARI-20208 Repository: ambari Description ------- Adding dependency of kafka broker's listeners config to populate accurate port for Atlas atlas.kafka.bootstrap.servers property. Diffs (updated) ----- ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml 15cc73b ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py a450d4d ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 2d7bcd3 Diff: https://reviews.apache.org/r/57139/diff/3/ Changes: https://reviews.apache.org/r/57139/diff/2-3/ Testing ------- Verified dependency of : listeners propert for following cases: 1) Simple environment with listener's value as : PLAINTEXT://localhost:<port> 2) Kerberos environment with listener's value as : PLAINTEXTSASL://localhost:<different_port> 3) Kerberos environment with listener's value as : PLAINTEXTSASL://localhost:<different_port>,PLAINTEXT://localhost:<port> 4) Kerberos environment with listener's value as : PLAINTEXT://localhost:<port> :: in this case it will pickup the port given for PLAINTEXT protocol only (as SASL port is not specified). Thanks, Vishal Suvagia