> On March 4, 2017, 2:33 a.m., Jaimin Jetly wrote: > > ambari-web/app/models/configs/theme/sub_section_tab.js > > Line 84 (original), 84-87 (patched) > > <https://reviews.apache.org/r/57268/diff/1/?file=1655325#file1655325line84> > > > > Whats the reason behind making this computed property volatile ?
Adding volatile here is because I keep getting inconsistent result on this computed property during manual test, so add volatile to make sure the value is consistent even it's updated more than once in one digest loop. - Richard ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57268/#review167925 ----------------------------------------------------------- On March 3, 2017, 7:34 a.m., Richard Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57268/ > ----------------------------------------------------------- > > (Updated March 3, 2017, 7:34 a.m.) > > > Review request for Ambari, Jaimin Jetly and Yusaku Sako. > > > Bugs: AMBARI-20287 > https://issues.apache.org/jira/browse/AMBARI-20287 > > > Repository: ambari > > > Description > ------- > > Take subSectionTab into consideration on show/hide > > > Diffs > ----- > > ambari-web/app/models/configs/theme/sub_section.js 7274569 > ambari-web/app/models/configs/theme/sub_section_tab.js 2262882 > ambari-web/app/views/common/configs/service_config_layout_tab_view.js > 466a88d > ambari-web/test/models/configs/theme/sub_section_tab_test.js 0c3b98c > > > Diff: https://reviews.apache.org/r/57268/diff/1/ > > > Testing > ------- > > Manully tested on live cluster. All unit tests passed. > 20560 passing (25s) > 153 pending > > > Thanks, > > Richard Zang > >
