----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57089/ -----------------------------------------------------------
(Updated Март 7, 2017, 3:11 п.п.) Review request for Ambari, Alejandro Fernandez, Sid Wagle, and Vitalyi Brodetskyi. Bugs: AMBARI-19835 https://issues.apache.org/jira/browse/AMBARI-19835 Repository: ambari Description ------- HDP 3.0 support for Slider with configs, kerberos, widgets, metrics, quicklinks, and themes Flatten from HDP 2.0.6 - 2.6 into common-services, and reference in HDP 3.0 In HDP 3.0, we have created a new stack definition that does not inherit from other stacks, in order to reduce the complexity of having to analyze older stacks. This means that we need to create a service definition (metainfo.xml, configs, kerberos, widgets, metrics, quicklinks, and themes) that is equivalent to what is inherit and deleted from all of the previous stacks. A merge needs to account for additions, overrides, and deletions. metainfo.xml and configs perform a merge of older versions kerberos.json always seems to override the previous file Because the bits for this service may not yet be available in the HDP 3.0 repo, the task is to ensure that /api/v1/stacks/HDP/versions/2.6/services/SLIDER (which uses inheritance) is equivalent to the flattening of /api/v1/stacks/HDP/versions/3.0/services/SLIDER . Please take a look at how this was done for ZK, HDFS, and YARN/MR. This means that you will not be able to actually install the service for now, but can still perform validation during the Install Wizard that the correct components and configs show up. Diffs (updated) ----- ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/configuration/slider-client.xml PRE-CREATION ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/configuration/slider-env.xml PRE-CREATION ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/configuration/slider-log4j.xml PRE-CREATION ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/kerberos.json PRE-CREATION ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/metainfo.xml PRE-CREATION ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/files/hbaseSmokeVerify.sh PRE-CREATION ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/__init__.py PRE-CREATION ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/params.py PRE-CREATION ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/params_linux.py PRE-CREATION ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/params_windows.py PRE-CREATION ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/service_check.py PRE-CREATION ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/slider.py PRE-CREATION ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/slider_client.py PRE-CREATION ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/templates/storm-slider-env.sh.j2 PRE-CREATION ambari-server/src/main/resources/stacks/HDP/3.0/services/SLIDER/metainfo.xml PRE-CREATION Diff: https://reviews.apache.org/r/57089/diff/3/ Changes: https://reviews.apache.org/r/57089/diff/2-3/ Testing ------- Unit tests passed Thanks, Dmytro Sen