> On March 7, 2017, 11:53 a.m., Sebastian Toader wrote: > > ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py > > Lines 158 (patched) > > <https://reviews.apache.org/r/57344/diff/1/?file=1656769#file1656769line187> > > > > Could this deadlock in case the worker process is killed from outside > > thus being shut down without properly closing the mp_result_queue?
No. Queues is closed on process relaunch and every place that blocked will be unblocked by IOError. - Eugene ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57344/#review168101 ----------------------------------------------------------- On March 7, 2017, 3:28 p.m., Eugene Chekanskiy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57344/ > ----------------------------------------------------------- > > (Updated March 7, 2017, 3:28 p.m.) > > > Review request for Ambari, Attila Doroszlai, Andrew Onischuk, Dmytro Sen, > Robert Levas, and Sebastian Toader. > > > Bugs: AMBARI-20323 > https://issues.apache.org/jira/browse/AMBARI-20323 > > > Repository: ambari > > > Description > ------- > > All status command execution logic moved under one file. > > * added protection for hardkilling(now process tries to die gracefully) > * added protection for queue internal logic blocking(underlying pipes hard > closed) > * added lock around queues that will prevent from using queues before new one > will be created in case of recreating executor process > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/ActionQueue.py 5300b52 > ambari-agent/src/main/python/ambari_agent/Controller.py 61a74e6 > ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 2f15770 > ambari-agent/src/main/python/ambari_agent/main.py 3f333c4 > ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 9fefefb > ambari-agent/src/test/python/ambari_agent/TestController.py 663e215 > ambari-agent/src/test/python/ambari_agent/TestMain.py 97c448b > > > Diff: https://reviews.apache.org/r/57344/diff/2/ > > > Testing > ------- > > mvn clean test, manual testing > > > Thanks, > > Eugene Chekanskiy > >
