> On March 8, 2017, 4:23 a.m., Mugdha Varadkar wrote: > > Ship It!
Thanks for your review Mugdha! - Shi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57396/#review168246 ----------------------------------------------------------- On March 7, 2017, 10:45 p.m., Shi Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57396/ > ----------------------------------------------------------- > > (Updated March 7, 2017, 10:45 p.m.) > > > Review request for Ambari, Mugdha Varadkar and Robert Levas. > > > Bugs: AMBARI-20329 > https://issues.apache.org/jira/browse/AMBARI-20329 > > > Repository: ambari > > > Description > ------- > > AMBARI-18425 add PAM support for ranger authentication in Ambari, but every > time restart ranger-admin it will generate the files again, which will > overwrite the user change. Need to check first if these files already exist, > do not generate again. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 15f7cf7 > > > Diff: https://reviews.apache.org/r/57396/diff/1/ > > > Testing > ------- > > 1. Change ranger pam files > 2. Restart ranger > 3. Check if pam files settings will be overwritten by template. > > > Thanks, > > Shi Wang > >