----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57451/#review168511 -----------------------------------------------------------
Ship it! +1. I agree, especially if HBase client is added on this host, and at a later time HDFS client is added. - Alejandro Fernandez On March 9, 2017, 8 a.m., zhangxiaolu zhangxiaolu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57451/ > ----------------------------------------------------------- > > (Updated March 9, 2017, 8 a.m.) > > > Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid > Wagle, and Yusaku Sako. > > > Bugs: AMBARI-20368 > https://issues.apache.org/jira/browse/AMBARI-20368 > > > Repository: ambari > > > Description > ------- > > The problem is caused by the wrong installation order, which means > hbase-client will be installed before the installation of hdfs-client. Under > such circumstance, installation of hdfs-client will fail because the > hadoop-conf-dir does not exist. > Two solutions can be provided to solve this problem: > 1. Creating the hadoop-conf-dir in hbase.py; > 2. Setting correct installation order in role_command_order.json; > Considering that hdfs-client may not beinstalled on the node especially when > adding new host, therefore, in my opinion, the second choice would be more > appropriate. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py > 20894ec > > > Diff: https://reviews.apache.org/r/57451/diff/1/ > > > Testing > ------- > > done it > > > Thanks, > > zhangxiaolu zhangxiaolu > >
