----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57493/#review168726 -----------------------------------------------------------
Ship it! Ship It! - Aravindan Vijayan On March 10, 2017, 2:57 a.m., Yusaku Sako wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57493/ > ----------------------------------------------------------- > > (Updated March 10, 2017, 2:57 a.m.) > > > Review request for Ambari, Jaimin Jetly, Prajwal Rao, Richard Zang, and Vivek > Ratnavel Subramanian. > > > Bugs: AMBARI-20391 > https://issues.apache.org/jira/browse/AMBARI-20391 > > > Repository: ambari > > > Description > ------- > > See https://issues.apache.org/jira/browse/AMBARI-20391 > > https://github.com/grafana/grafana/blob/v2.6.0/public/app/core/services/backend_srv.js#L68-L70 > was adding extra subpath even though the URL already contains it. The fix > was to use the backendSrv.datasourceRequest, and not use backendSrv.get > directly. > > > Diffs > ----- > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js 3a0fb66 > > > Diff: https://reviews.apache.org/r/57493/diff/1/ > > > Testing > ------- > > Tested manually with a reverse proxy with subpath configured per > http://docs.grafana.org/installation/behind_proxy/. > There are currently no unit tests covering the data source, so no tests are > included. > > > Thanks, > > Yusaku Sako > >
