----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57429/#review169028 -----------------------------------------------------------
Ship it! Ship It! - Juanjo Marron On March 15, 2017, 4:33 p.m., Sangeeta Ravindran wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57429/ > ----------------------------------------------------------- > > (Updated March 15, 2017, 4:33 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Gaurav Nagar, Juanjo > Marron, and Nitiraj Rathore. > > > Bugs: AMBARI-20352 > https://issues.apache.org/jira/browse/AMBARI-20352 > > > Repository: ambari > > > Description > ------- > > When the number of workflows exceeds 15, you can see additional pages in the > workflow dashboard. > The pag number calculation is not correct. On page 2, the page number is > displayed as 1.666666666666665. > > This is because roundedStart is not calculated based on the number of records > a page holds (jobs.pageSize). > > var roundedStart = this.get('jobs.start') - this.get('jobs.start') % 10; > > Fix is to use the jobs.pageSize instead. > > > Diffs > ----- > > > contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js > 5f92d6f > > > Diff: https://reviews.apache.org/r/57429/diff/1/ > > > Testing > ------- > > Manual Tessting. > Build failure is unrelated. > > > Thanks, > > Sangeeta Ravindran > >
