----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57683/ -----------------------------------------------------------
(Updated March 16, 2017, 4:40 p.m.) Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, Oliver Szabo, Robert Levas, Sandor Magyari, and Sebastian Toader. Changes ------- Changed apache JIRA Bugs: AMBARI-20482 https://issues.apache.org/jira/browse/AMBARI-20482 Repository: ambari Description ------- 1. Install Ambari 2. Set up LDAP/AD and sync users 3. Create a local user with the same name as one of the LDAP users. 4. Invoke the http://c6401:8080/api/v1/users/ API. The duplicate user will be displayed along with the other users with data loaded for the local user. 5. Invoking the Invoke the http://c6401:8080/api/v1/users/<duplicateuser> API will result in Http 500 error. Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java d9a7997 ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java 5659cc5 ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java e69bbc9 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java e370a8a ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UserDAOTest.java a1ca11d ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java 2ca5396 ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UsersTest.java 0364213 Diff: https://reviews.apache.org/r/57683/diff/2/ Testing ------- 1. Wrote new unit tests 2. Manually tested the following scenarios: 1. LDAP sync to existing local user, convert mode, 2. LDAP sync to existing local user, skip mode, 3. Trying to create local user over LDAP user 3. All unit tests pass in ambari-server Thanks, Balázs Bence Sári