----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57910/#review170151 -----------------------------------------------------------
Ship it! Ship It! - Myroslav Papirkovskyy On Березень 27, 2017, 1:32 після полудня, Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57910/ > ----------------------------------------------------------- > > (Updated Березень 27, 2017, 1:32 після полудня) > > > Review request for Ambari, Myroslav Papirkovskyy, Sumit Mohanty, and Sid > Wagle. > > > Bugs: AMBARI-20559 > https://issues.apache.org/jira/browse/AMBARI-20559 > > > Repository: ambari > > > Description > ------- > > The class should be: > 1\. Thread-safe > 2\. Support caching for multiple clusters > 3\. Write cache to json file for debug purposes. > > In next jiras the class with be derived by ClusterConfigurationCache, > ClusterTopologyCache and ClusterComponentsStatusCache. > > We have already a caching class for alerts. The jira should also rewrite it to > use the base class. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/ClusterCache.py PRE-CREATION > ambari-agent/src/main/python/ambari_agent/ClusterConfiguration.py 72b87be > ambari-agent/src/main/python/ambari_agent/ClusterConfigurationCache.py > PRE-CREATION > ambari-agent/src/main/python/ambari_agent/Controller.py 78b5c0c > ambari-agent/src/main/python/ambari_agent/FileCache.py d0c8bdb > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 7f3b2a5 > ambari-agent/src/test/python/ambari_agent/TestAlerts.py 64479a2 > ambari-agent/src/test/python/ambari_agent/TestClusterConfigurationCache.py > a418f6d > > > Diff: https://reviews.apache.org/r/57910/diff/5/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
