----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57968/#review170266 -----------------------------------------------------------
ambari-agent/pom.xml Lines 420 (patched) <https://reviews.apache.org/r/57968/#comment243067> Maybe doing it the other way around and including only the dependencies what are needed instead of what are not needed would be more robust. When I added the zkmigrator, there were only 2 dependencies in the pom.xml, since then someone added hadoop-common and 5 others. If we'll keep adding new dependnecies this exclude list will need to be maintained. - Attila Magyar On March 27, 2017, 7:43 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57968/ > ----------------------------------------------------------- > > (Updated March 27, 2017, 7:43 p.m.) > > > Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene > Chekanskiy, Laszlo Puskas, and Sebastian Toader. > > > Bugs: AMBARI-20544 > https://issues.apache.org/jira/browse/AMBARI-20544 > > > Repository: ambari > > > Description > ------- > > Prune files contained in the Ambari agent jcepolicyinfo.jar file to a minimal > set. > > The files (classes, etcs...) in the _shaded_ JAR come from unrelated or > unneeded dependencies. This is causing bloat and may cause unnecessary > licensing issues. > > > Diffs > ----- > > ambari-agent/pom.xml 292fd07 > > > Diff: https://reviews.apache.org/r/57968/diff/1/ > > > Testing > ------- > > Manualy tested jar. > > > Thanks, > > Robert Levas > >