----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58009/#review170349 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java Lines 33 (patched) <https://reviews.apache.org/r/58009/#comment243162> Remove this type of comment and add a description of what it does. ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java Lines 45 (patched) <https://reviews.apache.org/r/58009/#comment243163> Nitpick put some newline before Inject, Override, and function signature ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java Lines 61 (patched) <https://reviews.apache.org/r/58009/#comment243164> Shouldn't policy be required? Can first check its value before checking the other properties. And if the value is http, then yarn.timeline-service.webapp.address is required, otherwise, then yarn.timeline-service.webapp.https.address is required. ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java Lines 67 (patched) <https://reviews.apache.org/r/58009/#comment243165> Spaces before and after braces, and after commas ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml Lines 745 (patched) <https://reviews.apache.org/r/58009/#comment243161> YARN with all caps - Alejandro Fernandez On March 28, 2017, 10:27 p.m., Madhuvanthi Radhakrishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58009/ > ----------------------------------------------------------- > > (Updated March 28, 2017, 10:27 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit > Mohanty. > > > Bugs: AMBARI-20612 > https://issues.apache.org/jira/browse/AMBARI-20612 > > > Repository: ambari > > > Description > ------- > > A new property called yarn.log.server.web-service.url was added in HDP 2.6 > It takes value from yarn.timeline-service.webapp.address if the > yarn.http.policy is HTTP_ONLY and takes value from > yarn.timeline-service.webapp.https.address if the yarn.http.policy is > HTTPS_ONLY. > The logic works on fresh installs but is not present during upgrades from > HDP2.x to HDP2.6 > Fix is to provide the upgrade packs for it. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml > c8f93e4 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml > 3c0769a > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml > 53caa52 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml > 66f1a64 > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml > 0d6f51b > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml > 44d0a2a > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrlTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58009/diff/1/ > > > Testing > ------- > > HDP upgrade from 2.5->2.6 > Unit tests > > > Thanks, > > Madhuvanthi Radhakrishnan > >