----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58051/#review170616 -----------------------------------------------------------
Ship it! Ship It! - Jayush Luniya On March 29, 2017, 10:51 p.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58051/ > ----------------------------------------------------------- > > (Updated March 29, 2017, 10:51 p.m.) > > > Review request for Ambari, Jayush Luniya, Oliver Szabo, and Sumit Mohanty. > > > Bugs: AMBARI-20624 > https://issues.apache.org/jira/browse/AMBARI-20624 > > > Repository: ambari > > > Description > ------- > > As part of this ticket following changes are done: > # swagger spec file will be committed to ambari project at path: > ambari-server/docs/api/generated/swagger.json > # swagger doc file in html format will be auto-generated and committed at > path: ambari-server/docs/api/generated/index.html > # ascidoc directory with md files will not be maintained > # currently swagger spec file had some validation errors. these errors has > been addressed. > > > Diffs > ----- > > ambari-server/docs/api/asciidoc/definitions.adoc 76beb8c > ambari-server/docs/api/asciidoc/overview.adoc e9e5649 > ambari-server/docs/api/asciidoc/paths.adoc d756051 > ambari-server/docs/api/generated/index.html PRE-CREATION > ambari-server/docs/api/generated/swagger.json PRE-CREATION > ambari-server/pom.xml 618d21f > > ambari-server/src/main/java/org/apache/ambari/server/api/services/groups/GroupPrivilegeService.java > 8a23885 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/groups/GroupService.java > ad9db28 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/groups/MemberService.java > ec02511 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/users/ActiveWidgetLayoutService.java > 30714d4 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserAuthorizationService.java > e6fda46 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserPrivilegeService.java > d6b4b29 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserService.java > ad9c485 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewDataMigrationService.java > 388f454 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewInstanceService.java > 9657c0e > > ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewPermissionService.java > cbc037b > > ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewPrivilegeService.java > e6d817f > > ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewService.java > 1936d5b > > ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewVersionService.java > ed6ddb1 > > > Diff: https://reviews.apache.org/r/58051/diff/1/ > > > Testing > ------- > > verified that the swagger spec file has no validation error. > verified that html doc file is generated as expected. > > > Thanks, > > Jaimin Jetly > >
