----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58122/#review171001 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java Lines 523 (patched) <https://reviews.apache.org/r/58122/#comment243836> For performance, please avoid string concatenation, just use a long string as it is or use a stringbuffer/stringbuilder. - Di Li On April 3, 2017, 10:42 p.m., Amruta Borkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58122/ > ----------------------------------------------------------- > > (Updated April 3, 2017, 10:42 p.m.) > > > Review request for Ambari, Di Li and Robert Nettleton. > > > Bugs: AMBARI-20551 > https://issues.apache.org/jira/browse/AMBARI-20551 > > > Repository: ambari > > > Description > ------- > > Following error is thrown while exporting a blueprint from cluster. > ERROR [ambari-client-thread-8726] ReadHandler:99 - Bad request: > java.lang.IllegalArgumentException: Specified configuration type is not > associated with any service: storm-site > at > org.apache.ambari.server.controller.internal.Stack.getServiceForConfigType(Stack.java:494) > at > org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$StackPropertyTypeFilter.isPropertyIncluded(BlueprintConfigurationProcessor.java:2946) > at > org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.shouldPropertyBeExcludedForBlueprintExport(BlueprintConfigurationProcessor.java:939) > at > org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doFilterPriorToExport(BlueprintConfigurationProcessor.java:439) > at > org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForBlueprintExport(BlueprintConfigurationProcessor.java:416) > at > org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.createBlueprintResource(ClusterBlueprintRenderer.java:186) > at > org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.finalizeResult(ClusterBlueprintRenderer.java:141) > at org.apache.ambari.server.api.query.QueryImpl.getResult(QueryImpl.java:839) > at org.apache.ambari.server.api.query.QueryImpl.execute(QueryImpl.java:223) > at > org.apache.ambari.server.api.handlers.ReadHandler.handleRequest(ReadHandler.java:77) > at > org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:145) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > db1aa074d4 > > > Diff: https://reviews.apache.org/r/58122/diff/2/ > > > Testing > ------- > > Tested manually. Log shows warning about unmapped config-type but blueprint > gets exported. > > > Thanks, > > Amruta Borkar > >
