> On April 10, 2017, 5:19 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py > > Lines 49 (patched) > > <https://reviews.apache.org/r/58277/diff/1/?file=1686585#file1686585line49> > > > > This should actually be False by default. > > Jayush Luniya wrote: > Technically yes default should be False. However we have to ensure that > there are no regressions if versionAdvertised is not passed in some code path > in the command.json. Using versionAdvertised=True ensures that we are not > regressing the past behavior.
Default in metainfo.xml is False. We should maintain that consistency in EU/RU, at least for now, especially since this may impact custom services. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58277/#review171447 ----------------------------------------------------------- On April 7, 2017, 11:47 p.m., Madhuvanthi Radhakrishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58277/ > ----------------------------------------------------------- > > (Updated April 7, 2017, 11:47 p.m.) > > > Review request for Ambari, Jayush Luniya and Sumit Mohanty. > > > Bugs: AMBARI-20696 > https://issues.apache.org/jira/browse/AMBARI-20696 > > > Repository: ambari > > > Description > ------- > > The custom services do not advertise any version and hence will not > participate in the HDP upgrade process. So selectors need not be called. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py > c510dac060 > > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py > 79393b985f > > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py > 02ae62daf3 > > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py > ff00a1f38e > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > 0d1ef13c21 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 77d5bf89db > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 751ce085d8 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java > e42bd45cc1 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py > 1609050409 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java > 71a02f5e5a > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 554e089102 > > > Diff: https://reviews.apache.org/r/58277/diff/1/ > > > Testing > ------- > > Installed HDP Regular services with HDF Custom services - Nifi, Strealine, > Registry > Python unit tests > Java unit tests > > > Thanks, > > Madhuvanthi Radhakrishnan > >
