> On 四月 11, 2017, 6:41 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py > > Lines 67 (patched) > > <https://reviews.apache.org/r/57451/diff/5/?file=1686957#file1686957line67> > > > > I'm thinking more about this, what happens if Ambari Agent is running > > as non-root? > > > > Perhaps we should instead > > 1. introduce Role Command Order rules to handle this scenario > > OR > > 2. look for a fix in HDFS Client so that it doesn't fail if hadoop conf > > dir doesn't exist. > > > > I prefer option #2 since components should all be idempotent. > > > > How frequently does this happen? Is it only during UI, or BP installs? > > zhangxiaolu zhangxiaolu wrote: > It happened frequently especially installing all services in first time?I > hasn't tested it in BP.
And i'm confused if tried again three times and it would passed when installing all services in first time. - zhangxiaolu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57451/#review171602 ----------------------------------------------------------- On 四月 10, 2017, 7:37 a.m., zhangxiaolu zhangxiaolu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57451/ > ----------------------------------------------------------- > > (Updated 四月 10, 2017, 7:37 a.m.) > > > Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid > Wagle, and Yusaku Sako. > > > Bugs: AMBARI-20368 > https://issues.apache.org/jira/browse/AMBARI-20368 > > > Repository: ambari > > > Description > ------- > > The problem is caused by the wrong installation order, which means > hbase-client will be installed before the installation of hdfs-client. Under > such circumstance, installation of hdfs-client will fail because the > hadoop-conf-dir does not exist. > Two solutions can be provided to solve this problem: > 1. Creating the hadoop-conf-dir in hbase.py; > 2. Setting correct installation order in role_command_order.json; > Considering that hdfs-client may not beinstalled on the node especially when > adding new host, therefore, in my opinion, the second choice would be more > appropriate. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py > 8ad802e > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py > cffec06 > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py > 42bc989 > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py > 9bb0dd7 > > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py > 60022e1 > > > Diff: https://reviews.apache.org/r/57451/diff/5/ > > > Testing > ------- > > done it > > > File Attachments > ---------------- > > AMBARI-20368.patch > > https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch > > > Thanks, > > zhangxiaolu zhangxiaolu > >
